Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TeamMember.role #1094

Merged
merged 13 commits into from Nov 17, 2023
Merged

feat: add TeamMember.role #1094

merged 13 commits into from Nov 17, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Aug 24, 2023 •
edited

Summary

This PR adds the new TeamMember.role field and corresponding TeamMemberRole enum.
Additionally removes the now-deprecated .permissions field, which was never documented here (but used to be documented in the API docs).

discord/discord-api-docs@80b0958
discord/discord-api-docs@b6db1da

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Aug 24, 2023
@shiftinv shiftinv marked this pull request as ready for review August 24, 2023 17:56
@shiftinv shiftinv added this to the disnake v2.10 milestone Aug 25, 2023
@shiftinv shiftinv marked this pull request as draft September 10, 2023 15:59
@shiftinv shiftinv changed the base branch from master to refactor/owner-ids September 22, 2023 18:18
@shiftinv
Copy link
Member Author

shiftinv commented Sep 22, 2023 •
edited

This is now blocked by #1109.

Additionally, Bot.is_owner now only considers team members with the admin or developer roles "bot owners" (since those can access the bot token), excluding read_only members.

@shiftinv shiftinv marked this pull request as ready for review September 22, 2023 18:20
@shiftinv shiftinv added the s: blocked Issue/PR is blocked by other issues label Sep 22, 2023
Base automatically changed from refactor/owner-ids to master September 23, 2023 10:22
@shiftinv shiftinv removed the s: blocked Issue/PR is blocked by other issues label Sep 23, 2023
shiftinv added a commit that referenced this pull request Oct 30, 2023
@shiftinv
fix(team): don't rely on undocumented permissions field (partial ba…
6fed323 
…ckport of #1094)
@shiftinv shiftinv merged commit cd48c92 into master Nov 17, 2023
27 checks passed
@shiftinv shiftinv deleted the feature/team-roles branch November 17, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shiftinv