Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typing): update send method types to support StandardSticker #1134

Merged
merged 4 commits into from Dec 9, 2023
Merged

feat(typing): update send method types to support StandardSticker #1134

merged 4 commits into from Dec 9, 2023

Conversation

shiftinv
Copy link
Member

Summary

Bots can now send standard stickers, similar to all normal users. This PR updates the .send and .create_thread typings accordingly, no runtime change needed.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added the t: refactor/typing/lint Refactors, typing changes and/or linting changes label Nov 17, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 17, 2023
EQUENOS
EQUENOS approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@EQUENOS EQUENOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shiftinv shiftinv force-pushed the feature/send-standard-stickers branch from 39de2e8 to b661d31 Compare December 9, 2023 10:42
@shiftinv shiftinv merged commit f780cf5 into master Dec 9, 2023
27 checks passed
@shiftinv shiftinv deleted the feature/send-standard-stickers branch December 9, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EQUENOS EQUENOS EQUENOS approved these changes

Assignees
No one assigned
Labels
t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftinv @EQUENOS