Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shard): handle RECONNECT opcode during initial connection flow #1155

Merged
merged 3 commits into from Jan 20, 2024

Conversation

shiftinv
Copy link
Member

Summary

The first op we receive when connecting should never be anything other than HELLO, but apparently Discord thinks otherwise.
Instead of crashing completely, we now just attempt to perform the requested reconnect.

ref: https://canary.discord.com/channels/808030843078836254/1198023852601659412

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv enabled auto-merge (squash) January 20, 2024 16:39
@shiftinv shiftinv merged commit a24abf4 into master Jan 20, 2024
27 checks passed
@shiftinv shiftinv deleted the fix/gateway-reconnect-hello branch January 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants