Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarification to executable param #1158

Merged
merged 2 commits into from Feb 23, 2024

Conversation

Skelmis
Copy link
Contributor

@Skelmis Skelmis commented Feb 19, 2024

Summary

This PR adds some clarifying documentation around the executable parameters of audio classes based off of internal discussions.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Skelmis Skelmis changed the title doc: add clarification to executable param docs: add clarification to executable param Feb 19, 2024
@shiftinv shiftinv added the t: documentation Improvements or additions to documentation/examples label Feb 19, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Feb 19, 2024
@EQUENOS EQUENOS merged commit cc1776a into DisnakeDev:master Feb 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants