Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): reconnect on protocol errors #1159

Merged
merged 3 commits into from Mar 24, 2024

Conversation

shiftinv
Copy link
Member

Summary

see this thread

WSMessage(type=<WSMsgType.ERROR: 258>, data=WebSocketError(<WSCloseCode.PROTOCOL_ERROR: 1002>, 'Received fragmented control frame'), extra=None)

This isn't reproducible1, but apparently happened at least once. Blame cloudflare, I guess(?).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Footnotes

  1. ...unless you manually feed it one of these weird non-spec-compliant frames: bot._get_websocket(shard_id=0).socket._reader._protocol.data_received(bytes([0b00001001, 0]))

@shiftinv shiftinv added this to the disnake v2.10 milestone Feb 23, 2024
@shiftinv shiftinv merged commit ce8d276 into master Mar 24, 2024
27 checks passed
@shiftinv shiftinv deleted the fix/gateway-protocol-error-reconnect branch March 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant