Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Reduce number of Unknowns in public APIs. #1167

Merged
merged 4 commits into from Mar 24, 2024

Conversation

elenakrittik
Copy link
Contributor

@elenakrittik elenakrittik commented Mar 19, 2024

Summary

Reduces the amount of unknown types in public-facing APIs. Intended to improve experience with disnake when using pyright in strict mode. I intentionally didn't go too deep and only focused on untyped *args/**kwargs here since they are (from my experience, at least) one of the most common untyped things when using disnake.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@elenakrittik elenakrittik marked this pull request as ready for review March 19, 2024 14:40
@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Mar 19, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 19, 2024
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv enabled auto-merge (squash) March 24, 2024 14:25
@shiftinv shiftinv merged commit 62dee68 into DisnakeDev:master Mar 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants