Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarl in oauth2 url generator #1191

Open
OseSem opened this issue May 14, 2024 · 0 comments
Open

yarl in oauth2 url generator #1191

OseSem opened this issue May 14, 2024 · 0 comments
Labels
feature request Request for a new feature

Comments

@OseSem
Copy link
Contributor

OseSem commented May 14, 2024

Summary

Using yarl for adding params to the oauth url.

What is the feature request for?

The core library

The Problem

If anything goes wrong with wrong params atleast it gives an error and does not just return it. Also right now there are a lot of if calls after eachother while it can be fixed with 1 function.
https://github.com/DisnakeDev/disnake/blob/master/disnake/utils.py#L322-L332

The Ideal Solution

You use yarl.URL("standard oauth url").with_query(params) or yarl.build().

The Current Solution

No response

Additional Context

No response

@OseSem OseSem added the feature request Request for a new feature label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant