Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Guild): missing return in get_command #333

Merged
merged 1 commit into from Feb 8, 2022
Merged

fix(Guild): missing return in get_command #333

merged 1 commit into from Feb 8, 2022

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Feb 7, 2022 •
edited

Summary

as title, fixes a missing return and updates the docstring (partially taken from #275)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint or pre-commit run --all-files
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added bug Something isn't working s: needs review Issue/PR is awaiting reviews labels Feb 7, 2022
Victorsitou
Victorsitou requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@Victorsitou Victorsitou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring is wrong (alternatively a Return would be nice)
image

@shiftinv shiftinv changed the title Fix Guild.get_command fix(Guild): missing return in get_command Feb 7, 2022
@shiftinv
Copy link
Member Author

shiftinv commented Feb 7, 2022 •
edited

The docstring is already mostly fixed by #275, could fix it there with all the other documentation updates:
image

onerandomusername
onerandomusername approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. On the fence about the docstring, tho.

@shiftinv shiftinv force-pushed the fix/guild-get-command branch 2 times, most recently from 3c74358 to 6e27f50 Compare February 7, 2022 19:34
@EQUENOS EQUENOS merged commit 9184311 into master Feb 8, 2022
@shiftinv shiftinv deleted the fix/guild-get-command branch February 14, 2022 20:31
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EQUENOS EQUENOS EQUENOS approved these changes

@Victorsitou Victorsitou Victorsitou approved these changes

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shiftinv @EQUENOS @Victorsitou @onerandomusername