Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Guild.widget_image_url #365

Merged
merged 2 commits into from Feb 19, 2022
Merged

fix Guild.widget_image_url #365

merged 2 commits into from Feb 19, 2022

Conversation

owocado
Copy link
Contributor

@owocado owocado commented Feb 19, 2022

Summary

Hi,

I observed that the URL generated by Guild.widget_image_url() method was missing /api/ parent endpoint, it generates:

https://discord.com/guilds/{guild_id}/widget.png?style={style}

However, as per Discord API docs examples on widget image example, URL should be:

https://discord.com/api/guilds/{guild_id}/widget.png?style={style}

which properly renders as correct widget image.

This PR hopefully fixes this issue. 馃槄

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint or pre-commit run --all-files
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

I suppose this is what I get for not testing it again after changing it :>

@shiftinv shiftinv merged commit 2ae3c1c into DisnakeDev:master Feb 19, 2022
@owocado owocado deleted the patch-1 branch February 19, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants