Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support interactions in UserConverter/MemberConverter #429

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 23, 2022

Summary

Adds support for ApplicationCommandInteraction to commands.UserConverter and .MemberConverter. While slash commands don't use these converters and instead use the builtin option type, these converters may still be called manually.

Also improves the channel_types error message, which is somewhat but not really related. I just didn't feel like opening a separate PR for a change of a few characters

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added bug Something isn't working s: needs review Issue/PR is awaiting reviews labels Mar 23, 2022
@shiftinv shiftinv added this to the disnake v2.5 milestone Mar 23, 2022
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onerandomusername onerandomusername enabled auto-merge (squash) April 14, 2022 15:37
@onerandomusername onerandomusername merged commit fa97fb3 into DisnakeDev:master Apr 14, 2022
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 14, 2022
@shiftinv shiftinv deleted the fix/user-member-converters-interaction branch April 15, 2022 02:07
shiftinv added a commit that referenced this pull request Jul 19, 2022
* fix: support interactions in UserConverter/MemberConverter

* fix: improve channel_types error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants