Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decorator-based autocompleters #521

Merged
merged 1 commit into from May 9, 2022
Merged

fix: decorator-based autocompleters #521

merged 1 commit into from May 9, 2022

Conversation

Sharp-Eyes
Copy link
Member

Summary

Decorator-based autocompleters failed because of a bug introduced in #501 (my bad 馃槶) because the autocomplete function would be copied but not updated with the new slash command instance. To fix this, we now manually overwrite them inside _ensure_assignment_on_copy.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added bug Something isn't working s: needs review Issue/PR is awaiting reviews labels May 9, 2022
@onerandomusername onerandomusername merged commit 2f93645 into DisnakeDev:master May 9, 2022
shiftinv pushed a commit that referenced this pull request May 10, 2022
@Sharp-Eyes @shiftinv
fix: paste command instance on autocomplete copies (#521)
ab93219
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label May 20, 2022
@onerandomusername onerandomusername mentioned this pull request Jul 12, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sharp-Eyes @onerandomusername @shiftinv