Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle optional locales properly #533

Merged
merged 1 commit into from May 23, 2022
Merged

fix: handle optional locales properly #533

merged 1 commit into from May 23, 2022

Conversation

shiftinv
Copy link
Member

Summary

Locale fields should be set to None instead of creating a Locale.unknown_None proxy value.
Regression from #439

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added bug Something isn't working s: needs review Issue/PR is awaiting reviews labels May 21, 2022
onerandomusername
onerandomusername approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@onerandomusername onerandomusername merged commit 743ed5b into master May 23, 2022
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label May 23, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone May 23, 2022
@onerandomusername onerandomusername deleted the fix/locale-optional branch May 23, 2022 01:08
onerandomusername pushed a commit that referenced this pull request Jul 17, 2022
@shiftinv @onerandomusername
fix: handle optional locales properly (#533)
e9d7e5b 
fixes a regression from GH-439
onerandomusername pushed a commit to shiftinv/disnake that referenced this pull request Jul 17, 2022
@shiftinv @onerandomusername
fix: handle optional locales properly (DisnakeDev#533)
17c5b82 
fixes a regression from DisnakeDevGH-439
onerandomusername pushed a commit to shiftinv/disnake that referenced this pull request Jul 17, 2022
@shiftinv @onerandomusername
fix: handle optional locales properly (DisnakeDev#533)
1aa9390 
fixes a regression from DisnakeDevGH-439
@onerandomusername onerandomusername added s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftinv @onerandomusername