Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: don't install cchardet on py >3.9 #702

Merged
merged 5 commits into from Aug 13, 2022
Merged

deps: don't install cchardet on py >3.9 #702

merged 5 commits into from Aug 13, 2022

Conversation

shiftinv
Copy link
Member

Summary

Limits the installation of cchardet to Python versions 3.9 and below, mirroring the aiohttp change aio-libs/aiohttp#6857.
While cchardet appears to work fine on 3.10, it's been unmaintained for more than a year, and as such there are no wheels built for versions newer than 3.9. This breaks the install of the [speed] extra on systems using 3.10 without build tools.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added p: low Low priority s: needs review Issue/PR is awaiting reviews t: dependencies Addition/update/removal of dependencies labels Aug 11, 2022
@shiftinv shiftinv added this to the disnake v2.6 milestone Aug 11, 2022
onerandomusername
onerandomusername requested changes Aug 13, 2022
View reviewed changes
changelog/702.misc.rst Outdated Show resolved Hide resolved
@onerandomusername onerandomusername enabled auto-merge (squash) August 13, 2022 20:31
@onerandomusername onerandomusername merged commit e5c9f46 into DisnakeDev:master Aug 13, 2022
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Aug 13, 2022
@shiftinv shiftinv deleted the deps/cchardet-extra-py310 branch August 13, 2022 22:45
onerandomusername added a commit that referenced this pull request Sep 29, 2022
@onerandomusername
deps: don't install cchardet on py >3.9 (#702)
d3a9c59
onerandomusername added a commit that referenced this pull request Sep 29, 2022
@onerandomusername
deps: don't install cchardet on py >3.9 (#702)
2767fbd
onerandomusername added a commit that referenced this pull request Sep 29, 2022
@onerandomusername
deps: don't install cchardet on py >3.9 (#702) (#772)
f4f6103 
This is a backport of e5c9f46 to v2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
p: low Low priority t: dependencies Addition/update/removal of dependencies
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftinv @onerandomusername