fix: revert to weakrefs for user cache #858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This largely reverts cb2363f.
Users were not being evicted as expected, resulting in objects being retained solely in the user cache, with no other strong references.
See https://docs.python.org/3.10/library/weakref.html#weakref.WeakValueDictionary and https://docs.python.org/3.10/reference/datamodel.html#object.del.
The difference in performance and memory usage is insignificant, at least in 3.10; haven't tested other versions, but this is a bug regardless of version.
To reproduce, anything that uses
state.store_user
can be used, for example theGUILD_BAN_REMOVE
handler:With the previous implementation, the second
print
would output the user (assuming members intent is enabled) - with the changes in this PR, both printNone
as expected.(for context, this was originally noticed a while ago in an internal channel here)
Checklist
task lint
task pyright