Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(StageInstance): add guild_scheduled_event field to create instance #882

Merged
merged 13 commits into from Sep 29, 2023
Merged

feat(StageInstance): add guild_scheduled_event field to create instance #882

merged 13 commits into from Sep 29, 2023

Conversation

Victorsitou
Copy link
Member

Summary

discord/discord-api-docs#5687

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Dec 1, 2022
@shiftinv shiftinv added this to the disnake v2.8 milestone Dec 1, 2022
@shiftinv shiftinv added the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Dec 3, 2022
shiftinv
shiftinv approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple documentation nits, looks good to me otherwise

changelog/882.feature.rst Outdated Show resolved Hide resolved
disnake/channel.py Outdated Show resolved Hide resolved
Victorsitou and others added 3 commits December 7, 2022 16:18
@Victorsitou @shiftinv
docs: minor changes
327e90a 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou
Merge branch 'master' into feat/new-field-stage-instance-2
757bf9f
@Victorsitou
Merge branch 'master' into feat/new-field-stage-instance-2
9d9cd3a
@shiftinv shiftinv removed this from the disnake v2.8 milestone Feb 5, 2023
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Sep 29, 2023
@shiftinv
Copy link
Member

At last, API docs for this have been merged - this is good to go now.

shiftinv
shiftinv reviewed Sep 29, 2023
View reviewed changes
disnake/channel.py Outdated Show resolved Hide resolved
@shiftinv
docs: update versionadded
6653eba 
Signed-off-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@shiftinv shiftinv merged commit e38ba27 into DisnakeDev:master Sep 29, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Victorsitou @shiftinv