New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MessageFlags.suppress_notifications
and flags
parameter
#929
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Code review)
Lgtm! Should we deprecate suppress_embeds
eventually?
Perhaps, yeah. Something I forgot to mention - this PR currently doesn't add a |
Yeah, we should add them. |
Yeah let's add this parameter to edit methods as well |
Alrighty, added in c83dfe9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, passed my tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Adds
MessageFlags.suppress_notifications
(discord/discord-api-docs#5910), and implements aflags
parameter on allsend
-like methods.Checklist
task lint
task pyright