Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update sphinx to 6.0.1 #936

Merged
merged 6 commits into from Feb 19, 2023
Merged

deps: update sphinx to 6.0.1 #936

merged 6 commits into from Feb 19, 2023

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Feb 19, 2023

Summary

update sphinx to 6.0.1. This is semi-untested, making a pr for the rtd preview.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: documentation Improvements or additions to documentation/examples t: dependencies Addition/update/removal of dependencies labels Feb 19, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Feb 19, 2023
@onerandomusername onerandomusername added the s: needs review Issue/PR is awaiting reviews label Feb 19, 2023
@onerandomusername onerandomusername changed the title update sphinx to 6.1.3 deps: update sphinx to 6.1.3 Feb 19, 2023
@onerandomusername onerandomusername marked this pull request as ready for review February 19, 2023 20:25
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onerandomusername onerandomusername marked this pull request as draft February 19, 2023 21:22
@shiftinv
Copy link
Member

Update, search issue seems to be this one: sphinx-doc/sphinx#11163. We should pin sphinx==6.0.1 or wait for an update (don't think there's an eta yet).

@shiftinv shiftinv added the s: blocked Issue/PR is blocked by other issues label Feb 19, 2023
@onerandomusername onerandomusername changed the title deps: update sphinx to 6.1.3 deps: update sphinx to 6.0.1 Feb 19, 2023
@onerandomusername onerandomusername marked this pull request as ready for review February 19, 2023 21:58
@shiftinv shiftinv removed the s: blocked Issue/PR is blocked by other issues label Feb 19, 2023
@shiftinv shiftinv merged commit f588657 into master Feb 19, 2023
@shiftinv shiftinv deleted the tooling/sphinx-6.0 branch February 19, 2023 23:00
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: dependencies Addition/update/removal of dependencies t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants