Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not duplicate event entries when searching. #945

Merged
merged 12 commits into from Feb 25, 2023
Merged

fix: Do not duplicate event entries when searching. #945

merged 12 commits into from Feb 25, 2023

Conversation

elenakrittik
Copy link
Contributor

@elenakrittik elenakrittik commented Feb 21, 2023 •
edited

Summary

Closes #944

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews labels Feb 21, 2023
@Victorsitou Victorsitou added this to the disnake v2.9 milestone Feb 21, 2023
@shiftinv
Copy link
Member

This doesn't seem to resolve the original issue:
image

@elenakrittik
Copy link
Contributor Author

Looks like Sphinx did some implications or assumptions for base object path due to all other objects being defined with disnake.ext.commands. prefix. I think this is resolved now.

@shiftinv
Copy link
Member

This change results in the Bot.on_message_command_error description now linking to commands.on_slash_command_error instead of Bot.on_slash_command_error like before; same with Bot.on_user_command_error.

other than that, lgtm

@elenakrittik
Copy link
Contributor Author

This change results in the Bot.on_message_command_error description now linking to commands.on_slash_command_error instead of Bot.on_slash_command_error like before; same with Bot.on_user_command_error.

Good catch, thanks! This is fixed now.

@elenakrittik
Copy link
Contributor Author

Oh wait it's not

@onerandomusername
Copy link
Member

Oh wait it's not

It is fixed for me.

@elenakrittik
Copy link
Contributor Author

It is fixed for me.

Oh, well, that must be caching i guess
https://shouldiblamecaching.com/

@shiftinv shiftinv merged commit 5b3e102 into DisnakeDev:master Feb 25, 2023
@elenakrittik elenakrittik deleted the fix/event-entry-duplicates branch February 25, 2023 22:52
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername left review comments

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

Duplicated disnake.disnake in Event Reference for commands framework in docs
4 participants
@elenakrittik @shiftinv @onerandomusername @Victorsitou