Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AutoMod): add support for custom_message #954

Merged
merged 7 commits into from Feb 26, 2023
Merged

feat(AutoMod): add support for custom_message #954

merged 7 commits into from Feb 26, 2023

Conversation

Victorsitou
Copy link
Member

Summary

discord/discord-api-docs#5955

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou marked this pull request as ready for review February 24, 2023 21:00
@Victorsitou Victorsitou added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Feb 24, 2023
@Victorsitou Victorsitou added this to the disnake v2.9 milestone Feb 24, 2023
shiftinv
shiftinv reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple nits, but looks good to me otherwise c:

disnake/automod.py Outdated Show resolved Hide resolved
disnake/automod.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Feb 25, 2023
Victorsitou and others added 3 commits February 25, 2023 22:48
@Victorsitou @shiftinv
make it optional
f919fb8 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
@Victorsitou
feat: apply suggestions
717dedd
@Victorsitou
Merge branch 'master' into feat/automod-custom-message
a7c2864
@Victorsitou @onerandomusername
Update disnake/automod.py
d08fa37 
Co-authored-by: arl <genericusername414@gmail.com>
Signed-off-by: Victor <67214928+Victorsitou@users.noreply.github.com>
shiftinv
shiftinv approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@shiftinv shiftinv enabled auto-merge (squash) February 26, 2023 19:31
@shiftinv shiftinv merged commit 73f08a7 into DisnakeDev:master Feb 26, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Victorsitou @shiftinv @onerandomusername