Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: member not being cached in Guild.getch_members in the case of user_ids of length one #974

Merged
merged 4 commits into from Mar 5, 2023
Merged

fix: member not being cached in Guild.getch_members in the case of user_ids of length one #974

merged 4 commits into from Mar 5, 2023

Conversation

EQUENOS
Copy link
Member

@EQUENOS EQUENOS commented Mar 5, 2023

Summary

Guild.get_or_fetch_members uses Guild.fetch_member in case user_ids contains only 1 unresolved ID. However, it does not cache the value afterwards, which is certainly a bug that we missed.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@EQUENOS EQUENOS added p: low Low priority s: needs review Issue/PR is awaiting reviews t: bugfix labels Mar 5, 2023
thehaffk
thehaffk suggested changes Mar 5, 2023
View reviewed changes
disnake/guild.py Show resolved Hide resolved
disnake/guild.py Outdated Show resolved Hide resolved
thehaffk
thehaffk reviewed Mar 5, 2023
View reviewed changes
disnake/guild.py Outdated Show resolved Hide resolved
@EQUENOS EQUENOS merged commit fe2690b into master Mar 5, 2023
@EQUENOS EQUENOS deleted the fix/getch_members branch March 5, 2023 16:32
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Apr 6, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@thehaffk thehaffk thehaffk approved these changes

Assignees
No one assigned
Labels
p: low Low priority t: bugfix
Projects
None yet
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EQUENOS @shiftinv @thehaffk @onerandomusername