Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On timeout listener #992

Closed
solumath opened this issue Mar 30, 2023 · 1 comment · Fixed by #1024
Closed

On timeout listener #992

solumath opened this issue Mar 30, 2023 · 1 comment · Fixed by #1024
Labels
bug Something isn't working t: documentation Improvements or additions to documentation/examples

Comments

@solumath
Copy link

solumath commented Mar 30, 2023

Summary

Add on_timeout_listener(...)

What is the feature request for?

disnake.ext.commands

The Problem

There should be listener for when user is timed out. As it stands now there is only on_member_update which passes before and after member's current_timeout.
But it is not logical that i quote from docs: "Called when a Member updates their profile."
Users can't update their own timeout... Which suggests that there should be a listener for this. Or atleast if there is update to member then the member who did the changes should be passed alongside before, after.

The Ideal Solution

Implement on_timeout_update which will listen to timeout updates for members or include interaction with the user who updated the user.

The Current Solution

None

Additional Context

No response

@solumath solumath added the feature request Request for a new feature label Mar 30, 2023
@shiftinv
Copy link
Member

This is a documentation issue, imo. The wording could be improved, ... updates their profile is no longer accurate.
A new on_timeout_update event seems unnecessary, and may cause more confusion since timeout expiry does not trigger a gateway event.

then the member who did the changes should be passed along side before, after.

The user who modified the timeout is only retrievable through audit logs, it's unfortunately not part of the gateway event data.

@shiftinv shiftinv added bug Something isn't working t: documentation Improvements or additions to documentation/examples and removed feature request Request for a new feature labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working t: documentation Improvements or additions to documentation/examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants