Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auditlog): handle options.channel_id null value #995

Merged
merged 4 commits into from Apr 28, 2023
Merged

fix(auditlog): handle options.channel_id null value #995

merged 4 commits into from Apr 28, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Apr 2, 2023 •
edited

Summary

With the introduction of new automod trigger types for usernames/nicknames, audit log data for automod actions can contain entry.options.channel_id == null (or ""). This PR fixes the resulting deserialization issue.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.9 milestone Apr 2, 2023
@Skelmis Skelmis mentioned this pull request Apr 9, 2023
Closed
@shiftinv shiftinv mentioned this pull request Apr 11, 2023
Open
8 tasks
@shiftinv shiftinv mentioned this pull request Apr 17, 2023
Merged
8 tasks
@shiftinv
Copy link
Member Author

I've gone ahead and moved a part of this into a separate PR (#1009) - those changes are closely related, but not required for this bugfix.

@shiftinv shiftinv changed the title fix(auditlog): handle options.channel_id null value, return threads in addition to channels fix(auditlog): handle options.channel_id null value Apr 17, 2023
@shiftinv shiftinv merged commit 7c8814b into master Apr 28, 2023
24 checks passed
@shiftinv shiftinv deleted the fix/auditlog branch April 28, 2023 14:51
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
shiftinv added a commit that referenced this pull request Jun 21, 2023
@shiftinv
fix(auditlog): handle options.channel_id null value (#995)
520f97a 
With the introduction of new automod trigger types for
usernames/nicknames, audit log data for automod actions can contain
`entry.options.channel_id == null` (or `""`). This PR fixes the resulting deserialization issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername Awaiting requested review from onerandomusername

Assignees
No one assigned
Labels
needs backport: 2.8 t: bugfix
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftinv @onerandomusername