Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with 4.20.0 #145

Closed
noraj opened this issue Dec 28, 2018 · 8 comments
Closed

Incompatible with 4.20.0 #145

noraj opened this issue Dec 28, 2018 · 8 comments

Comments

@noraj
Copy link
Contributor

noraj commented Dec 28, 2018

noraj a commenté le 2018-12-26 15:27

evdi 1.5.1 is not building for 4.20.0 (manjaro) ...

mwawrzyniak a commenté le 2018-12-26 19:21

I uploaded a new release to fix building in 4.20 kernels. The error in make.log related to something removed in 4.20 (torvalds/linux@04cfcc7#diff-43768cc89c01c730cb119634b42dfa81).

The functionality wasn't apparently stable enough to be worthwhile. Removing it should have no effect on kernels < 4.20 either.

See the patch here https://aur.archlinux.org/cgit/aur.git/commit/?h=evdi&id=432d29bbfafebcf62be0d5930c6f87c16ac6fa12

@displaylink-dkurek
Copy link
Contributor

We are preparing new release which will address problems with compatibility with new kernels. We have fix for 4.20 version. Will close this issue after the code reaches github.

@NathanDeckinga
Copy link

I just rolled up to 4.20 on Fedora 29 and ran into this. Thanks for the update and I look forward to the release. As I'm getting the issue currently, let me know if you need any info and I'll try it out as soon as it makes it to git (with feedback if needed).

Thanks again!

@tobikl1
Copy link

tobikl1 commented Jan 25, 2019

Edited 2018-02-13

Apparently what i did is highly discouraged as mentioned in this related thread

Don't do this

for Fedora 29 and kernel 4.20 i got an error when trying to run

dkms build evdi/1.5.1

i just edited /var/lib/dkms/evdi/1.5.1/source/evdi_drv.h and added the line

#define FBINFO_CAN_FORCE_OUTPUT 1

right after

#define DRIVER_PATCHLEVEL 1

then i ran

dkms build evdi/1.5.1
dkms install evdi/1.5.1

which fixed the problem for me.

If you have to...

maybe think about doing this

PS
I am not familiar with this module, not even the language. I am using a Laptop at work for developing and have two displays connected via a docking station. With the kernel update from time to time the evdi module breaks and the DisplayLink service fails starting, making my two external screens unusable. In order to be able to continue working i was just looking for a quick fix. I was fully aware it was dirty and i barely (arguably not at all) knew what i was doing, but it solved the error and the service was starting up again. I did not create a pull request but just wanted to save some other peoples times who have a similar mindset. obviously you should just get the latest version as soon as it gets available.
i agree, i should have pointed out the fact, that this most likely is not at all the appropriate way of doing it. i am fine with downvoting the comment as well, since it is not.
i'd just ask that you comment on this message directly, next time, so i have a chance of editing it accordingly.
found a reason for the downvote in a different thread by chance.

@noraj
Copy link
Contributor Author

noraj commented Jan 25, 2019

It is working with evdi 1.5.1 (with AUR 1.5.1-2 and its patch) and kernel 4.20.3-1-MANJARO.

I don't know if Manjaro flavored kernel patch something compared to the vanilla kernel.

@lfuelling
Copy link

lfuelling commented Feb 6, 2019

@displaylink-dkurek can you say when exactly the fix (that's apparently still held back) will be released to GitHub?

@displaylink-dkurek
Copy link
Contributor

Sorry for no response - we have a bit of a slip. We are aiming for beginning of the next week.

@NathanDeckinga
Copy link

Slips happen. Is it still looking like this week though, @displaylink-dkurek ?

@displaylink-dkurek
Copy link
Contributor

displaylink-dkurek commented Feb 19, 2019

So, finally its there :)
evdi repository has been updated with quite some number of changes.
We are shifting towards 'atomic modeset', which means we are dropping
support for kernels older than 4.2.
With this change we did bump-up the evdi/libevdi versions, so for compatibility
please install new DisplayLinkManager (v5.1), which can be downloaded from here:
https://www.displaylink.com/downloads/ubuntu
Hope you will like it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants