Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pphtml should not treat "CSS used but not defined" as a "FAIL" #4

Closed
windymilla opened this issue Jan 2, 2021 · 2 comments
Closed

Comments

@windymilla
Copy link

windymilla commented Jan 2, 2021

It is not an error if a class name is used on an element, but that class is not used as a selector in the CSS.
It may be a mistake, e.g. a typo, so I think it is correct to "warn" about it, but it should not be a "FAIL"

I think the relevant line of code is this one where the word "FAIL" should be changed to "warn"

@asylumcs
Copy link
Collaborator

asylumcs commented Jan 2, 2021

I agree. "FAIL" should more closely reflect what the CSS validator would flag. As long as it is still a "warn" it makes sense.

@cpeel
Copy link
Member

cpeel commented Nov 30, 2021

This was resolved in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants