-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate Yellowbrick Dependencies #52
Comments
@mariusvniekerk the current version is an mvp proof of concept, intended for development and not necessarily users. We've been having a lot of trouble with continuous integration testing (see #17 #20) and so we felt that pinning versions would be necessary to ensure we were all on the same page. That said, most of the libraries in requirements.txt are commented out, and only the following dependencies are pinned:
The others are mostly dependencies of these 5 and come into the requirements with You do, however, raise a good point - and we've recently been discussing what dependencies we want to include, and whether or not we want to include Seaborn and the entire pandas stack, or try to simplify the library. We have decided the following dependencies are going to be in Version 1:
I'm going to go ahead and make this issue reflect that goal so that we can discuss its impact here! |
Thanks, basically I wanted to build a conda package for yellowbrick. For CI purposes I would strongly advocate using conda and conda-forge to grab your dependencies. You can get latest versions of the various pydata stack libraries and it should be relatively easy to test against multiple different versions of scipy, sklearn and matplotlib. |
Excellent! We'd really appreciate a conda package contribution. Just note that we're about to make some significant changes to the underlying API, refactoring to our idea of "Visual Transformers" and "Visual Pipelines" to more closely align ourselves with the Scikit-Learn API. These changes are due October 6 in the 0.3 release of Yellowbrick, which will not be backwards compatible. |
Version 0.3.1 froze the dependencies as follows:
|
@mariusvniekerk -- I'll create a new issue for the conda package distribution. |
Lots of libraries are pinned to versions in the requirements.txt
Should this be the case?
The text was updated successfully, but these errors were encountered: