Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't display cart discounts on product in side cart #1758

Closed
qiqqq opened this issue Sep 24, 2018 · 1 comment
Closed

We shouldn't display cart discounts on product in side cart #1758

qiqqq opened this issue Sep 24, 2018 · 1 comment
Assignees
@mcspronko

Comments

@qiqqq
Copy link
Collaborator

qiqqq commented Sep 24, 2018

When we have cart discount rule or coupon code, we should show added discount in cart summary only. Now we show this discount on product directly and this is misleading:

https://prnt.sc/ky1hfl

On product we should show only product discount and not cart discount.
@mcspronko
Copy link
Collaborator

I would like to work on this issue.

@mcspronko mcspronko self-assigned this Jan 18, 2019
@mcspronko mcspronko changed the title We should'nt display cart discounts on product in side cart We shouldn't display cart discounts on product in side cart Jan 18, 2019
@mcspronko mcspronko mentioned this issue Jan 18, 2019
Merged
5 tasks
pkarw added a commit that referenced this issue Jan 18, 2019
@pkarw
Merge pull request #2247 from pronkoconsulting/1758-minicart-product-…
d921973 
…price-fix

We should'nt display cart discounts on product in side cart #1758
@filrak filrak closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcspronko mcspronko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcspronko @qiqqq @filrak