Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in section What we can improve? (feedback section) #2318

Closed
ibugaj opened this issue Jan 31, 2019 · 4 comments
Closed

Bug in section What we can improve? (feedback section) #2318

ibugaj opened this issue Jan 31, 2019 · 4 comments
Assignees
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Jan 31, 2019

Current behavior

Typo in text "Your feedback is important fo us. Let us know what we could improve." and lack of possibility to send feedback - notification that email address not provided

Expected behavior

Should be "Your feedback is important for us. Let us know what we could improve."
(it is about word "for")

Steps to reproduce the issue

  1. Finish buying the product
  2. In section What we can improve? fill some text and click on Give a feedback button

image

Environment details

demo.storefrontcloud.io

Additional information

I'm not sure if target emal address should be from fe. Magento or from where?

@filrak filrak added good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon bug Bug reports labels Jan 31, 2019
@Micheledinocera
Copy link

Working on this.

@pkarw pkarw closed this as completed Feb 2, 2019
pkarw added a commit that referenced this issue Feb 2, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 4, 2019

Typo corrected, but I still can't send feedback - I get notification "Invalid email address is provided!" and error 500 in Console.
Checked on https://test.storefrontcloud.io

@pkarw pkarw reopened this Feb 4, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 4, 2019

It seemingly works on test (at least for me :)) Could Youe please "Clear Storage" in the browser + restest on https://test.storefrontcloud.io
screenshot 2019-02-04 22 21 32
screenshot 2019-02-04 22 21 17

@pkarw pkarw assigned ibugaj and unassigned patzick Feb 4, 2019
@pkarw pkarw closed this as completed Feb 4, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 5, 2019

OK, now it works for me too:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

5 participants