Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection checkbox for receiving Newsletter isn't saved #2364

Closed
ibugaj opened this issue Feb 4, 2019 · 4 comments
Closed

selection checkbox for receiving Newsletter isn't saved #2364

ibugaj opened this issue Feb 4, 2019 · 4 comments
Assignees

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 4, 2019

Current behavior

Selection checkbox for receiving Newsletter isn't saved

Expected behavior

Selection checkbox for Newsletter should be saved

Steps to reproduce the issue

  1. Be a logged user
  2. Go to My account - My Newsletter
  3. Click on Edit newsletter preferences
  4. Select checkbox I want to receive a Newsletter, and agree to its terms
  5. Click on Update my preferences button
  6. Go to another page, for example My orders and back to My newsletter

Environment details

https://test.storefrontcloud.io/

Additional information

When user proceed steps 1-5 and then refresh page, then he will redirected on Home page with notification You need to be logged in to see this page (but user still stayed logged)

image

@vue-kacper
Copy link
Contributor

Reload of any "My account" section page (as authenticated user) redirects to home with this notification. I think it's related to SSR "My account" pages reload logic for unauthenticated user.

We've introduced it a while ago to redirect unauthenticated users from "My account" to "Homepage" on reload.

Maybe we should not redirect user at all in this scenario because we can't detect if user is authenticated on SSR

@pkarw
Copy link
Collaborator

pkarw commented Feb 4, 2019

@filrak I know that You were working on both: route guards + newsletter refactoring; can you check this one please?

@filrak
Copy link
Collaborator

filrak commented Feb 19, 2019

already spoke with @vue-kacper about it. he si gonna take care of this

@pkarw pkarw assigned vue-kacper and unassigned filrak Feb 19, 2019
@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

Related to #2754

@pkarw pkarw closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants