Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No quantity up/down buttons in product page and cart - Edge #2398

Closed
ArturDivante opened this issue Feb 8, 2019 · 6 comments
Closed

No quantity up/down buttons in product page and cart - Edge #2398

ArturDivante opened this issue Feb 8, 2019 · 6 comments
Assignees
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Milestone

Comments

@ArturDivante
Copy link
Collaborator

Current behavior

Quantity field does not have up and down buttons in Edge browser. You can still increase and decrease quantity by clicking the field and using up/down arrow keys or numbers.

Expected behavior

After moving mouse button over quantity field (on product page) or after clicking edit button (in cart), up and down buttons should appear and alow to set desired quantity by clicking them.

Steps to reproduce the issue

Scenario 1 (product page):

  1. Open https://demo.storefrontcloud.io or https://test.storefrontcloud.io on Edge browser
  2. Open any product page
  3. Move mouse cursor over quantity field
    productpage

Scenario 2 (cart):

  1. Open https://demo.storefrontcloud.io or https://test.storefrontcloud.io on Edge browser
  2. Add any product to the cart
  3. Open cart
  4. Click edit button next to the product
    cartpage

Can you handle fixing this bug by yourself?

NO.

Environment details

@pkarw pkarw added bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront labels Feb 8, 2019
@pkarw
Copy link
Collaborator

pkarw commented Feb 24, 2019

@patzick please do close this one if is it ready (I think it is :))

@patzick patzick added this to the 1.8.3 milestone Feb 26, 2019
@patzick
Copy link
Collaborator

patzick commented Feb 26, 2019

Yes, it is:)

@patzick patzick closed this as completed Feb 26, 2019
@ibugaj
Copy link
Collaborator

ibugaj commented Feb 27, 2019

@pkarw @patzick @ArturDivante I already reproduced this bug on Microsoft Edge HTML 17.17134

@ibugaj ibugaj reopened this Feb 27, 2019
@patzick
Copy link
Collaborator

patzick commented Feb 28, 2019

@ibugaj @ArturDivante @pkarw
Guys, i'm not sure we should change that in this case. It's the internal Edge behavior that numeric fields don't support spinner controls.
There is an issue for that: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/6762219/ and they are not in hurry to change that, but i think if someone is using Edge, then is used to have numeric fields without spinners.

Please share your opinion, but if we decide to change that field i think this should be as feature request in next versions than bug.

@pkarw
Copy link
Collaborator

pkarw commented Feb 28, 2019

I think we can ignore this one for now - it's a minor issure related only to Edge

@pkarw pkarw closed this as completed Feb 28, 2019
@ibugaj
Copy link
Collaborator

ibugaj commented Feb 28, 2019

I also think that it doesn't matter, especially that this browser is not so popular;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Development

No branches or pull requests

4 participants