Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color for picture of product #2419

Closed
ibugaj opened this issue Feb 11, 2019 · 5 comments
Closed

Wrong color for picture of product #2419

ibugaj opened this issue Feb 11, 2019 · 5 comments
Assignees
Labels
QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 11, 2019

Current behavior

Wrong color for picture of product

image

Expected behavior

Right color of product on picture.

Steps to reproduce the issue

  1. Go to any category of products
  2. Choose any color in Filters, for example green
  3. Click on any product to open its PDP

Environment details

https://test.storefrontcloud.io/

Additional information

This issue is reproducible not in every case. I found it for product with SKU: WH11-XS-Green
Futhermore: when I open dev console then color is changed on different and when I closed it, then it back for last color.
WHAT ELSE: when user choose some color on filter, open any PDP, then back to PLP and choose again the same color on filter, then products on page are reload, but color isn't changed for them - user must click again on this color in filter to change it.

@patzick patzick added the vs-hackathon Tasks for the Hackathon label Feb 11, 2019
@DaanKouters
Copy link
Collaborator

@patzick i'll take a look at this

@patzick patzick added this to the 1.9 milestone Feb 13, 2019
@pkarw pkarw closed this as completed Feb 18, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 19, 2019

Verified and main issue is solved, but there is still problem, when user choose any color on filter, next open any PDP, then back to PLP and choose again the same color on filter, then products on page are reload, but color isn't changed for them - user must click again on this color in filter to change it.

@DaanKouters
Copy link
Collaborator

Ah, i see what you mean. But i'm positive this is another issue and not related with this original issue.
But of course i leave this decision to Vue Storefront core team members.

@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 19, 2019

So should I open new issue for this?:)

@pkarw
Copy link
Collaborator

pkarw commented Feb 20, 2019

@ibugaj do open a new one, please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved on branch Testers will add this label after positive check on specific branch. vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants