Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can add to cart 0 qty product #2437

Closed
ibugaj opened this issue Feb 14, 2019 · 2 comments
Closed

User can add to cart 0 qty product #2437

ibugaj opened this issue Feb 14, 2019 · 2 comments
Assignees
Labels
bug Bug reports P1: Urgent Priority mark - high priority QA approved on branch Testers will add this label after positive check on specific branch.
Milestone

Comments

@ibugaj
Copy link
Collaborator

ibugaj commented Feb 14, 2019

Current behavior

User can add to cart 0 qty product (with price 0), has noification 'Product has been added to the cart!" - but in Cart 1 product appears

image

Expected behavior

There should be no possibility to change qty of product on 0.

Steps to reproduce the issue

  1. Open any Catalog page
  2. Click on any product
  3. On product page change qty on 0
  4. Click Add to cart
  5. Go to Cart

Environment details

https://test.storefrontcloud.io/

Additional information

I checked that user can also fill Qty field by negative number (after that the price displayed as negative.)
Issue also on mobile.

@RakowskiPrzemyslaw
Copy link
Contributor

@ibugaj I'll take care of that

@patzick patzick added the bug Bug reports label Feb 17, 2019
@pkarw pkarw added the P1: Urgent Priority mark - high priority label Feb 25, 2019
@patzick patzick added this to the 1.8.3 milestone Feb 26, 2019
patzick added a commit that referenced this issue Feb 26, 2019
…n_add_0_products

Bugfix/#2437 user can add 0 products
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Feb 26, 2019
@patzick patzick closed this as completed Feb 26, 2019
@ibugaj
Copy link
Collaborator Author

ibugaj commented Feb 26, 2019

Tested - Issue solved, user can't change qty on 0 (or less) by arrows. And for now even if user try to fill qty manually, then he get notification "Quantity must be above 0" - thanks for this solution :)
@patzick It will be good add it also on Cart, because when user open cart and try to change qty manually then there isn't notification "Quantity must be above 0" and user can left 0 or for example -2 in qty field (but the price works like for one product, and if user go to checkout then system will correct quantity on 1)
In Cart (filled manually):
image
In PDP (filled manually):
image

@ibugaj ibugaj added the QA approved on branch Testers will add this label after positive check on specific branch. label Feb 26, 2019
@ibugaj ibugaj removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P1: Urgent Priority mark - high priority QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Development

No branches or pull requests

4 participants