Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter feature not working at all #2558

Closed
filrak opened this issue Mar 7, 2019 · 10 comments
Closed

Newsletter feature not working at all #2558

filrak opened this issue Mar 7, 2019 · 10 comments
Assignees
Labels
bug Bug reports P2: Important Priority mark - still high ;) vs-hackathon Tasks for the Hackathon
Milestone

Comments

@filrak
Copy link
Collaborator

filrak commented Mar 7, 2019

Test

  • profile
  • indiv components
  • api
@filrak filrak self-assigned this Mar 7, 2019
@filrak filrak added bug Bug reports P2: Important Priority mark - still high ;) labels Mar 7, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone Mar 20, 2019
@pkarw pkarw added the vs-hackathon Tasks for the Hackathon label Apr 10, 2019
@mdesmet
Copy link
Contributor

mdesmet commented Apr 16, 2019

Hi,

Is this the mailchimp integration or rather integration with magento 2?

Maybe we can provide generic components and do the integration with either magento2 or maichimp in vue-storefront-api?

I'm actually working right now on mailchimp but also looking at replacing mailchimp with standard magento 2 functionality.

@mdesmet mdesmet mentioned this issue Apr 17, 2019
8 tasks
@pkarw
Copy link
Collaborator

pkarw commented Apr 23, 2019

Related to #2754

@pkarw pkarw closed this as completed May 21, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 23, 2019
@alinadivante
Copy link
Collaborator

@patzick @mdesmet hello guys, I tested newsletter on develop branch, but unfortunately it doesn't work..
When I try update my preferences I have errors in dev console.
image
Also when I use "Subscribe" button.

@alinadivante alinadivante reopened this May 27, 2019
@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@mdesmet
Copy link
Contributor

mdesmet commented May 27, 2019

@alinadivante: I will have a look tonight.

@mdesmet mdesmet mentioned this issue May 27, 2019
8 tasks
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 28, 2019
@patzick patzick closed this as completed May 28, 2019
@GabiDivante
Copy link
Collaborator

hi @mdesmet @patzick I tested changes on develop branch and an error appears when I try to subscribe newsletter from the footer or by changing preferences in my account (link to localhost)
Selection_071

@GabiDivante GabiDivante reopened this Jun 5, 2019
@GabiDivante GabiDivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 5, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 5, 2019

@GabiDivante this feature requies the latest / develop version of vue-storefront-api deployed - which is not currently available on any public demo instance. SO the question is if You're using the local api in order to test it out?

@mdesmet
Copy link
Contributor

mdesmet commented Jun 5, 2019

@GabiDivante, @pkarw : i'll retest this one. To be honest, i didn't retest the frontpage newsletter subscription with last changes.

@GabiDivante
Copy link
Collaborator

@pkarw I wasn't using the local API so probably that's the cause. @mdesmet that would be great, subscription from the front page for logged in users should work in the same way as changing subscriptions status in my account.

@pkarw
Copy link
Collaborator

pkarw commented Jun 8, 2019

@mdesmet can You Please update us with the status?

@mdesmet
Copy link
Contributor

mdesmet commented Jun 8, 2019

Hi, it's working for me. I'm able to subscribe from the front page, so probably indeed it was not linking to the new api.

@pkarw pkarw closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports P2: Important Priority mark - still high ;) vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

6 participants