Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product SKU in wishlist should be more visible #2606

Closed
ArturDivante opened this issue Mar 19, 2019 · 1 comment
Closed

Product SKU in wishlist should be more visible #2606

ArturDivante opened this issue Mar 19, 2019 · 1 comment
Assignees
@PanMisza
Labels
P4: Nice to have Priority mark - it's nice to have QA approved on branch Testers will add this label after positive check on specific branch.
Milestone
1.10.0-rc.1

Comments

@ArturDivante
Copy link
Collaborator

ArturDivante commented Mar 19, 2019 •
edited

Current behavior

Product SKU displayed in wishlist is almost invisible

wishlistSKU

Expected behavior

If product SKU is needed in that window, it should be reasonably visible (darker?)

Steps to reproduce the issue

  1. Add any product to wishlist
  2. Open wishlist sidebar

Repository

https://demo.storefrontcloud.io/

Can you handle fixing this bug by yourself?

no

Environment details

  • Browser: all
  • OS: all

Additional information

Single product can be added to wishlist many times - once for every size and color combination. SKU reflects those diffrences, so it should still be displayed here. However, currently font color is so bright, its barely readable on the white background.
@ArturDivante ArturDivante added the P4: Nice to have Priority mark - it's nice to have label Mar 19, 2019
@PanMisza PanMisza self-assigned this Mar 21, 2019
PanMisza added a commit to PanMisza/vue-storefront that referenced this issue Mar 21, 2019
@PanMisza
[vuestorefront#2606] - unification of sku color
b9d9018
@PanMisza PanMisza mentioned this issue Mar 21, 2019
Merged
5 tasks
PanMisza added a commit to PanMisza/vue-storefront that referenced this issue Mar 23, 2019
@PanMisza
[vuestorefront#2606] - update CHANGELOG.md
2109fba
@patzick patzick added this to the 1.10.0-rc.1 milestone Mar 24, 2019
patzick added a commit that referenced this issue Mar 24, 2019
@patzick
Merge pull request #2626 from PanMisza/improvement/2606
1b51682 
[#2606] - unification of sku color
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Mar 24, 2019
@patzick
Copy link
Collaborator

patzick commented Mar 24, 2019

Thanks @PanMisza !

@patzick patzick closed this as completed Mar 24, 2019
@ArturDivante ArturDivante added QA approved on branch Testers will add this label after positive check on specific branch. and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PanMisza PanMisza

Labels
P4: Nice to have Priority mark - it's nice to have QA approved on branch Testers will add this label after positive check on specific branch.
Projects
None yet
Milestone
1.10.0-rc.1
Development

No branches or pull requests
3 participants
@patzick @PanMisza @ArturDivante