Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Product added to cart' popup appears only once per product #2610

Closed
ArturDivante opened this issue Mar 19, 2019 · 2 comments
Closed

'Product added to cart' popup appears only once per product #2610

ArturDivante opened this issue Mar 19, 2019 · 2 comments
Assignees
Labels
3: Medium complexity bug Bug reports P4: Nice to have Priority mark - it's nice to have vs-hackathon Tasks for the Hackathon
Milestone

Comments

@ArturDivante
Copy link
Collaborator

Current behavior

Green confirmation popup 'Product has beed added to cart' is displayed only once.

Expected behavior

Confirmation popup should appear every time product is added to cart.

Steps to reproduce the issue

  1. Open any product page
  2. Add product to cart
  3. Add the same product again, without changing size or color

Repository

https://demo.storefrontcloud.io/

Can you handle fixing this bug by yourself?

no

Environment details

  • Browser: many
  • OS: many

Additional information

Adding diffrent products (even if its only size or color diffrence) will always trigger popup. But every time we add excalty the same product we already have in cart, confirmation is not displayed

@ArturDivante ArturDivante added the bug Bug reports label Mar 19, 2019
@pkarw
Copy link
Collaborator

pkarw commented Mar 19, 2019

Yes, there is code rule for this situation in case multiple notification with the same msg are stocked - we’re comparing the last msg when it’s exactly the same as current one no message is being shown. We probably need to change this condition to check if the prev message is still visible; if it’s not then it’s safe to show it again

@pkarw pkarw added P4: Nice to have Priority mark - it's nice to have 3: Medium complexity vs-hackathon Tasks for the Hackathon labels Mar 19, 2019
@JKrupinski
Copy link
Collaborator

I'll try this one

@patzick patzick added this to the 1.10.0-rc.1 milestone Mar 21, 2019
pkarw added a commit that referenced this issue Mar 23, 2019
#2610 - 'Product added to cart' popup appears only once per product
@pkarw pkarw closed this as completed Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports P4: Nice to have Priority mark - it's nice to have vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants