Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecesary options inside categories in hamburger menu #2612

Closed
ArturDivante opened this issue Mar 20, 2019 · 2 comments
Closed

Unnecesary options inside categories in hamburger menu #2612

ArturDivante opened this issue Mar 20, 2019 · 2 comments
Assignees
Labels
P4: Nice to have Priority mark - it's nice to have
Milestone

Comments

@ArturDivante
Copy link
Collaborator

ArturDivante commented Mar 20, 2019

Pieces of customer (my account) menu are replicated inside categories of hamburger menu, when customer is logged in.

Steps to reproduce the issue

  1. Login to customer account
  2. Open hamburger menu > Women / Men / Gear / Training

Current behavior

Categories contains set of extra links, under their sub-categories:
Women:

  • My Orders
  • My Loyalty Card
  • My Product Reviews

Men:

  • My Orders
  • My Loyalty Card
  • My Product Reviews

Gear:

  • My Loyalty Card
  • My Product Reviews

Training:

  • My Newsletter
  • My Orders
  • My Loyalty Card
  • My Product Reviews

Expected behavior

IMHO those links are unnecesary in hamburger menu, making it less clear. However if there is a reason to have them in menu, they shouldd be available from main menu, not stored inside categories.

Repository

https://demo.storefrontcloud.io/

Can you handle fixing this bug by yourself?

no

@ArturDivante ArturDivante added the P4: Nice to have Priority mark - it's nice to have label Mar 20, 2019
@bartdominiak
Copy link
Collaborator

Yeah, it shouldn't be here, but there is one reason to keep this data inside hamburger menu - Mobile users (0-767px). So, we've 2 options:

  1. Keep this data in Hamburger menu for mobile users, but move it to seperate category (like "My Account")
  2. Delete this data from hamburger menu, change visibility of "My Account" button also for small devices. (currently is hidden on mobile devices)

Please @filrak can you confirm which option should we take, and I'll provide a PR for that.

@Januszpl
Copy link
Contributor

@bartdominiak as far as I see it just need be removed from showing in subcategories.
"My account" is visible in opened menu on mobile devices
3773b21170c93793793a15533f89713c

After clicking My Account user can open it and see all this links - this is ok
27b79b8b619975f385096968509e0018

But opening subcategory like women (other categories) shows some of this "my account" links that should be removed (not visible here)
c6ae4fc70971a4aa1b288cfda44eaf31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4: Nice to have Priority mark - it's nice to have
Projects
None yet
Development

No branches or pull requests

4 participants