Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger Refactoring & display logs in SSR #2717

Closed
2 of 5 tasks
lukeromanowicz opened this issue Apr 12, 2019 · 0 comments
Closed
2 of 5 tasks

Logger Refactoring & display logs in SSR #2717

lukeromanowicz opened this issue Apr 12, 2019 · 0 comments
Assignees
Labels
1: Easy P2: Important Priority mark - still high ;) refactor Code refactoring
Milestone

Comments

@lukeromanowicz
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Logger has a lot of lines where the code could be slightly improved.
It is also lacking unit tests.
Last but not least, showing most of the logs in SSR is omitted and there is no way to display them.

What are the acceptance criteria

  • Logger has unit tests
  • Logger has improved code quality
  • It is possible to display debug and info in SSR
  • Only errors are shown by the default configuration.

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@lukeromanowicz lukeromanowicz added refactor Code refactoring P2: Important Priority mark - still high ;) 1: Easy labels Apr 12, 2019
@lukeromanowicz lukeromanowicz added this to the 1.10.0 milestone Apr 12, 2019
@lukeromanowicz lukeromanowicz self-assigned this Apr 12, 2019
@pkarw pkarw closed this as completed Apr 16, 2019
@pkarw pkarw modified the milestones: 1.10.0, 1.10.0-rc.1 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy P2: Important Priority mark - still high ;) refactor Code refactoring
Projects
None yet
Development

No branches or pull requests

2 participants