Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination on My orders page. #2810

Closed
2 of 5 tasks
alinadivante opened this issue Apr 26, 2019 · 2 comments
Closed
2 of 5 tasks

Pagination on My orders page. #2810

alinadivante opened this issue Apr 26, 2019 · 2 comments
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone
1.10.0-rc.1

Comments

@alinadivante
Copy link
Collaborator

What is the motivation for adding / enhancing this feature?

If user has a lot of orders, then he has to scroll and scroll the list..

my_orders

What are the acceptance criteria

A better solution would be to paginate on the My Orders page instead of scrolling through the entire list of orders.

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information
@alinadivante alinadivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Apr 26, 2019
@pkarw pkarw added vs-hackathon Tasks for the Hackathon 1: Easy labels Apr 26, 2019
@Hackbard
Copy link

i will give it a shot

Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810
2519f47 
Add the function bottomVisible to Helper couse we need it in two components
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810
76b9c73 
* Do some indention
* Use core helpers
* Add Logic to watch the scroll and determinate that we are on the end of the page and count the pagination up
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810
91ec40b 
Remove the bottomVisible method and use it from the core helper
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810 change changelog
e7213e9
@Hackbard Hackbard mentioned this issue May 24, 2019
Closed
7 tasks
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810
9364eb6 
* provide changelog message
* Move bottomVisible to core helper
* remove bottomVisible from Category
* Add new Module order-history
@Hackbard Hackbard mentioned this issue May 24, 2019
Merged
8 tasks
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810 add check to helper if we are on server side and r…
e4d7b2e 
…eturn true as default
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810 in case that we don't want a recrusion we set the …
02f7b48 
…default value to false
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810 fix using the wrong import; using store getters fo…
4fc3111 
…r orders history items
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810
7f3c520 
* Added bottomHelper
* Use bottomHelper in core pages Category and order history user Orders
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
vuestorefront#2810 remove trailing whitespace
f6b58e7
patzick added a commit that referenced this issue May 27, 2019
@patzick
Merge pull request #2956 from Hackbard/feature/2810-order-history-module
219dd6e 
#2810
@patzick patzick added this to the 1.10.0-rc.1 milestone May 27, 2019
@patzick
Copy link
Collaborator

patzick commented May 27, 2019

Thanks @Hackbard :)

@patzick patzick closed this as completed May 27, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@GabiDivante GabiDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Milestone
1.10.0-rc.1
Development

No branches or pull requests
5 participants
@pkarw @Hackbard @patzick @alinadivante @GabiDivante