Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some text from Order confirmation page and create new button #2818

Closed
2 of 5 tasks
alinadivante opened this issue Apr 26, 2019 · 4 comments
Closed
2 of 5 tasks
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented Apr 26, 2019

What is the motivation for adding / enhancing this feature?

Too much, unnecessary text on Order confirmation.

We have form "What we can improve?", so following text:

"E-mail us at demo@vuestorefront.io with any questions, suggestions how we could improve products or shopping experience"

is usless.

Also this information is unnecessary

Your Account
You can log to your account using e-mail and password defined earlier. On your account you can edit your profile data, check history of transactions, edit subscription to newsletter.

What are the acceptance criteria

Replace mentioned text with new button "Return to shopping"

image

I prepared design proposal:
image

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@alinadivante alinadivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Apr 26, 2019
@pkarw pkarw added the good first issue Tasks that requires just basic understanding of Vue Storefront label Apr 26, 2019
@patzick patzick added the vs-hackathon Tasks for the Hackathon label Apr 27, 2019
@ZeevGerstner
Copy link
Contributor

I will add this feature

@ZeevGerstner ZeevGerstner mentioned this issue Apr 28, 2019
8 tasks
patzick added a commit that referenced this issue Apr 29, 2019
@patzick patzick added this to the 1.10.0-rc.1 milestone Apr 29, 2019
@patzick
Copy link
Collaborator

patzick commented Apr 29, 2019

Thanks @ZeevGerstner ! :)

@patzick patzick closed this as completed Apr 29, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Apr 29, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 6, 2019
@alinadivante
Copy link
Collaborator Author

Thank u @ZeevGerstner

@ZeevGerstner
Copy link
Contributor

ZeevGerstner commented Jun 3, 2019

Glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants