Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of products. #2868

Closed
1 of 5 tasks
alinadivante opened this issue May 8, 2019 · 9 comments
Closed
1 of 5 tasks

Wrong order of products. #2868

alinadivante opened this issue May 8, 2019 · 9 comments
Assignees
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;)
Milestone

Comments

@alinadivante
Copy link
Collaborator

alinadivante commented May 8, 2019

Current behavior

If u set Sort by Price: Low to high and than you change category, you will see your saved sort selection, but order of the products will be the default.

image

sort_by

Expected behavior

After changing the category, the previous sorting selection shouldn't be saved or it should be applied.

Steps to reproduce the issue

  1. Go to any category
  2. Sort by for example Price: Low to high
  3. Change category
  4. Look at the order of products

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label May 8, 2019
@pkarw pkarw added this to the 1.10.0-rc.1 milestone May 8, 2019
@pkarw pkarw added 1: Easy P2: Important Priority mark - still high ;) labels May 8, 2019
@patzick patzick self-assigned this May 22, 2019
@pkarw pkarw modified the milestones: 1.10.0-rc.1, 1.11.0-rc.1 Jun 5, 2019
@Jensderond
Copy link
Contributor

I'm fixing this one

patzick added a commit that referenced this issue Jun 7, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 7, 2019
@patzick
Copy link
Collaborator

patzick commented Jun 7, 2019

Thanks, great job @Jensderond !

@patzick patzick closed this as completed Jun 7, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 10, 2019
@pkarw pkarw modified the milestones: 1.11.0-rc.1, 1.10.0-rc.1 Jun 19, 2019
@alinadivante alinadivante modified the milestones: 1.10.0-rc.1, 1.10.0 Aug 8, 2019
@alinadivante
Copy link
Collaborator Author

this bug returned again! 🐛

And please, look at this video:
Peek 2019-08-08 14-00

  • there are products with higher prices between those sorted.

@alinadivante alinadivante reopened this Aug 8, 2019
@patzick
Copy link
Collaborator

patzick commented Aug 9, 2019

The problem we have is not because of some logic. The final_price field in elastic is null, that's why sort order is broken in some cases.

image

@lukeromanowicz do you know a reason why some product does not have a final_price?

@lukeromanowicz lukeromanowicz self-assigned this Aug 9, 2019
@lukeromanowicz
Copy link
Contributor

IF ES product doesn't contain final_price and this is an unmodified result from ES then I would look for the root cause in the indexer. I'll try to take a look at that.

@pkarw
Copy link
Collaborator

pkarw commented Aug 9, 2019

I'd suggest to run full reindex and check it out. The final_price is being imported only when the renderCatalogRegularPrices and synchronizeCatalogSpecialPrices are set to true. We should double check the mage2vs import command if it's setting the PRODUCTS_SPECIAL_PRICES and PRODUCTS_RENDER_PRICES to true

@pkarw pkarw modified the milestones: 1.10.0, 1.11.0-rc.1 Aug 9, 2019
@pkarw pkarw removed the QA approved after merge Testers will add this label after positive check on merged changes label Aug 19, 2019
@pkarw
Copy link
Collaborator

pkarw commented Sep 10, 2019

@alinadivante can you please reimport and test this issue once again/

@pkarw pkarw removed this from the 1.11.0-rc.1 milestone Sep 10, 2019
@pkarw pkarw added this to the 2.0-rc milestone Sep 10, 2019
@alinadivante
Copy link
Collaborator Author

@pkarw I still have a problem with reindex/reimport, even if I made sure that the test_fullreindex.sh script is properly configured..

@pkarw
Copy link
Collaborator

pkarw commented Sep 12, 2019

I've checked it and the initial problem is seemingly fixed once and for all. The only issues I could find were related to cases of configurable product with let's say final_price set to 12 and then all the available configurable_children having higher prices. In that case, the issue is within the indexer that should update the root configurable product price.

https://www.dropbox.com/s/rfgigksmxl1il62/Screenshot%202019-09-12%2021.47.39.png?dl=0

SKU: WB03
name: Celeste Sport Bra

@pkarw pkarw closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports P2: Important Priority mark - still high ;)
Projects
None yet
Development

No branches or pull requests

5 participants