Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect value in PRAPI, when quantity is >1 #2874

Closed
2 of 5 tasks
ArturDivante opened this issue May 8, 2019 · 6 comments
Closed
2 of 5 tasks

Incorrect value in PRAPI, when quantity is >1 #2874

ArturDivante opened this issue May 8, 2019 · 6 comments
Assignees
Labels
3: Medium complexity bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@ArturDivante
Copy link
Collaborator

ArturDivante commented May 8, 2019

Current behavior

Summary during 'Instant checkout' displays only single product price - even when quantity was set diffrently. Other values (shipping, grand total) are displayed correctly.

Customer sees group of quotas and grand total, that does not match.

PRAPI

Expected behavior

Value displayed along with product name, should be calculated basen on quantity.

Steps to reproduce the issue

  1. Add any product to cart with quantity > 1
  2. Proceed t Instant checkout
  3. Check displayd summary

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser: Chrome
  • OS: Win10
@ArturDivante ArturDivante added the bug Bug reports label May 8, 2019
@pkarw pkarw added this to the 1.9.1 milestone May 8, 2019
@pkarw pkarw modified the milestones: 1.9.1, 1.10.0-rc.1 May 10, 2019
@pkarw pkarw closed this as completed May 10, 2019
@ArturDivante ArturDivante added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 10, 2019
@GabiDivante
Copy link
Collaborator

Hi @pkarw @ArturDivante @vishal-7037
I was testing this fix and I think that maybe we need a more complex solution.
There are two more situations where prices visible in the Instant Checkout Order summary are still different than in the cart, so again the customer sees a group of amounts and grand total, that does not match:

1. When an item has a reduced price due to some cart discount rule or discount code added.

In this situation, the 'Discount' line appears and the full prices of the listed products are visible in the Instant Checkout summary.
For now 'Discount' shows value only from the net price without tax, so the discount of the tax is missing, to have the correct equation.

So we can solve this in two ways:
a. show reduced prices and hide discount line
b. show correct discount value (with tax)

Look out for reduced price in the cart (currently not correct calculation - #2892).

2. When customer provided in his Shipping Details a country for which the tax is not included.

The prices without tax are visible in the cart, but in Instant Checkout summary customer sees the full prices with the tax.

@GabiDivante GabiDivante reopened this May 13, 2019
@GabiDivante GabiDivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 13, 2019
@GabiDivante
Copy link
Collaborator

Selection_030

@GabiDivante
Copy link
Collaborator

Selection_032

@GabiDivante
Copy link
Collaborator

GabiDivante commented May 13, 2019

below in the link, you can find the path showing the price change depending on the country given in the address

https://drive.google.com/file/d/16wo3fCXzgEIMJ-8RXnIuebO2fQ7Decve/view?usp=sharing

@pkarw pkarw closed this as completed Jun 11, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 11, 2019
@GabiDivante
Copy link
Collaborator

@qiqqq @patzick @pkarw
I tested changes on next and something is wrong again.
When I apply a discount code (mmtest - 50%) -> price visible next to the product is correct (it contains tax already) but in the Instant Checkout, the product price has tax value doubled.
Maybe this fix #2892 has not been taken into account.
We should show the same reduced price in the instant checkout as in the cart.
Peek 2019-06-18 10-50

@GabiDivante GabiDivante reopened this Jun 18, 2019
@GabiDivante GabiDivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 18, 2019
@GabiDivante GabiDivante added the QA rejected Testers will add this label when something is still wrong label Jun 18, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 18, 2019

Fixed

@pkarw pkarw closed this as completed Jun 18, 2019
@GabiDivante GabiDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA rejected Testers will add this label when something is still wrong labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

5 participants