Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR/CSR issue with Review pane on product Page #2888

Closed
1 of 5 tasks
pkarw opened this issue May 12, 2019 · 1 comment
Closed
1 of 5 tasks

SSR/CSR issue with Review pane on product Page #2888

pkarw opened this issue May 12, 2019 · 1 comment
Labels
3: Medium complexity bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented May 12, 2019

Current behavior

https://www.dropbox.com/s/qxlbba7yfvzn9e2/Screenshot%202019-05-12%2011.32.26.png?dl=0

There is an issue with refreshing the Review's pane when the user is logged in - in that case the HTML generated server side differs from the CSR version.

We had the same with User account and Wishlist after introducing lazy loading. @patzick I'm not sure what was the fix then? Can You take a look at it?

Expected behavior

There should be no SSR?CSR mismatch when user is being logged in on Ctrl+F5 (full reload)

Steps to reproduce the issue

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Code Version: 1.10rc-1
@pkarw
Copy link
Collaborator Author

pkarw commented Jun 3, 2019

I belive we just put the form into tag

patzick added a commit to patzick/vue-storefront that referenced this issue Jun 12, 2019
@pkarw pkarw closed this as completed Jun 12, 2019
pkarw added a commit to patzick/vue-storefront that referenced this issue Jun 12, 2019
pkarw added a commit that referenced this issue Jun 12, 2019
…duct-page-with-logged-in-user

Bugfix/#2888 ssr problem on product page with logged in user
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 12, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

3 participants