Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some structured data not available in product view #2910

Closed
1 of 5 tasks
pmaojo opened this issue May 16, 2019 · 6 comments
Closed
1 of 5 tasks

Some structured data not available in product view #2910

pmaojo opened this issue May 16, 2019 · 6 comments
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@pmaojo
Copy link
Contributor

pmaojo commented May 16, 2019

Current behavior

Current missing fields on Structured Data

Captura de pantalla 2019-05-16 a las 13 11 04

Expected behavior

Add all possible fields. url, image..

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@pmaojo pmaojo added the bug Bug reports label May 16, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 16, 2019

Hi @pmaojo could You please be more specific? :-) What do You mean by this and how do You see the actionable items regarding these fields? Adding the fields to Product page?

@pmaojo
Copy link
Contributor Author

pmaojo commented May 16, 2019

@pmaojo
Copy link
Contributor Author

pmaojo commented May 16, 2019

Well, this is not a bug really,
It could be an enhancement, so its a feature request.

@alinadivante alinadivante added feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can and removed bug Bug reports labels May 17, 2019
@pkarw
Copy link
Collaborator

pkarw commented May 17, 2019

OK, now I get it so it's all about setting up the proper micro-schema / metadata

@pkarw pkarw added 1: Easy vs-hackathon Tasks for the Hackathon labels May 17, 2019
@cewald
Copy link
Contributor

cewald commented May 24, 2019

We try to fill in the missing data.
Not all suggestions could be fulfilled with the demo data, but at least some.

patzick added a commit that referenced this issue May 27, 2019
@patzick patzick added this to the 1.10.0-rc.1 milestone May 27, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@patzick
Copy link
Collaborator

patzick commented May 27, 2019

Thanks @cewald !

@patzick patzick closed this as completed May 27, 2019
@GabiDivante GabiDivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

6 participants