Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "browse our catalog" as blue link. #2932

Closed
2 of 5 tasks
alinadivante opened this issue May 22, 2019 · 3 comments
Closed
2 of 5 tasks

Make "browse our catalog" as blue link. #2932

alinadivante opened this issue May 22, 2019 · 3 comments
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Milestone

Comments

@alinadivante
Copy link
Collaborator

What is the motivation for adding / enhancing this feature?

When the wish list or shopping cart is empty, the user can start browsing with one click on the "browse our catalog" link, but now we only have the hover effect on it. It will be better to highlight the "browse our catalog" link permanently.

image

What are the acceptance criteria

image
Let the "browse our catalog" link be blue.

Can you complete this feature request by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

@alinadivante alinadivante added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label May 22, 2019
@pkarw pkarw added vs-hackathon Tasks for the Hackathon good first issue Tasks that requires just basic understanding of Vue Storefront labels May 22, 2019
@pmaojo
Copy link
Contributor

pmaojo commented May 22, 2019

I think this should be applied to all links and the color of all links should be primary color defined in variables/_colors.scss, everywhere.

@Hackbard
Copy link

I will try to take care of it.

Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
Hackbard pushed a commit to Hackbard/vue-storefront that referenced this issue May 24, 2019
@patzick patzick added this to the 1.10.0-rc.1 milestone May 27, 2019
@patzick patzick added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label May 27, 2019
@patzick
Copy link
Collaborator

patzick commented May 27, 2019

Thanks @Hackbard ! ;D

@patzick patzick closed this as completed May 27, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront QA approved after merge Testers will add this label after positive check on merged changes vs-hackathon Tasks for the Hackathon
Projects
None yet
Development

No branches or pull requests

5 participants