Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getSearchAdapter always creates new instance for same adapterName #2960

Closed
1 of 2 tasks
abratko opened this issue May 24, 2019 · 0 comments
Closed
1 of 2 tasks

getSearchAdapter always creates new instance for same adapterName #2960

abratko opened this issue May 24, 2019 · 0 comments
Labels
3: Medium complexity bug Bug reports P2: Important Priority mark - still high ;) refactor Code refactoring
Milestone
1.10.0-rc.1

Comments

@abratko
Copy link

abratko commented May 24, 2019 •
edited
Loading

Current behavior

If you call getSearchAdapter successively several times with the same adapterName, a new instance will be created each time.

Expected behavior

If you call getSearchAdapter successively several times with the same adapterName, a new instance creates only once. Other calls should return existing instance.

Repository

https://github.com/DivanteLtd/vue-storefront/blob/master/core/lib/search/adapter/searchAdapterFactory.js

line 10

Can you handle fixing this bug by yourself?

  • YES
  • NO
@abratko abratko added the bug Bug reports label May 24, 2019
@pkarw pkarw added refactor Code refactoring 3: Medium complexity P2: Important Priority mark - still high ;) labels May 24, 2019
@abratko abratko mentioned this issue May 27, 2019
Closed
@patzick patzick added this to the 1.10.0-rc.1 milestone May 28, 2019
@abratko abratko mentioned this issue Jun 4, 2019
Merged
@pkarw pkarw closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3: Medium complexity bug Bug reports P2: Important Priority mark - still high ;) refactor Code refactoring
Projects
None yet
Milestone
1.10.0-rc.1
Development

No branches or pull requests
3 participants
@pkarw @abratko @patzick