Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong price is displayed for discount products. #3012

Closed
1 of 5 tasks
alinadivante opened this issue Jun 4, 2019 · 3 comments
Closed
1 of 5 tasks

Wrong price is displayed for discount products. #3012

alinadivante opened this issue Jun 4, 2019 · 3 comments
Labels
bug Bug reports

Comments

@alinadivante
Copy link
Collaborator

Current behavior

After adding discounted product to the cart, there is only a new price (with discount), but when I go offline I see also price before the discount.

discount

Expected behavior

We should displaying price without discount.

Steps to reproduce the issue

  1. Add to cart Joust Duffle Bag
  2. Open cart
  3. Go to offline mode

Repository

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@alinadivante alinadivante added the bug Bug reports label Jun 4, 2019
pkarw added a commit that referenced this issue Jun 4, 2019
@pkarw pkarw added the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 4, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 4, 2019

Fixed in the #2887

@alinadivante
Copy link
Collaborator Author

@pkarw without changes for products with Special Price (e.g. Joust Duffle Bag)

@alinadivante alinadivante removed the QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. label Jun 5, 2019
@pkarw
Copy link
Collaborator

pkarw commented Jun 5, 2019

Then the product has "static" special price (catalog rule) it could be showed in totals safely. We can't show the dynamic special prices (cart rules)

online mode:
https://www.dropbox.com/s/u02955txmbkhmpv/Screenshot%202019-06-05%2015.29.42.png?dl=0

offline mode:
https://www.dropbox.com/s/o88dfagx7mhdc5q/Screenshot%202019-06-05%2015.30.30.png?dl=0

This product has special price of 32 - set via catalog rule + applied discount by cart rule (only in online mode): so it works fine :)

@pkarw pkarw closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports
Projects
None yet
Development

No branches or pull requests

2 participants