Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar menu toggle button to product page. #3056

Closed
1 of 5 tasks
pmaojo opened this issue Jun 14, 2019 · 1 comment
Closed
1 of 5 tasks

Add sidebar menu toggle button to product page. #3056

pmaojo opened this issue Jun 14, 2019 · 1 comment
Assignees
Labels
1: Easy bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Milestone

Comments

@pmaojo
Copy link
Contributor

pmaojo commented Jun 14, 2019

What is the motivation for adding / enhancing this feature?

Thinking about the back button and the lack of menu on Product views.

Scenario:

1- User enters https://next.storefrontcloud.io/women/tops-women/tees-women/tees-25/elisa-evercool-and-trade-tee-1465.html?childSku=WS06
2- User can click back button (arrow-left icon) and it would on first click do nothing and second click take him out of the shop, bad.
3- User can wish to see a menu of links to browse the page on a standard way, and the hamburger menu is not present.

What are the acceptance criteria

On a product page:

  • There is no useless back button if the previous URL is not in our domain, or url was entered manually
  • There is a button to toggle side menu

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

I refer to the left arrow on the top left of the screenshot:
Captura de pantalla 2019-06-14 a las 18 38 39

@pmaojo pmaojo added the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Jun 14, 2019
@pkarw pkarw added the bug Bug reports label Jun 15, 2019
@pkarw pkarw modified the milestones: 1.10.0, 1.10.0-rc.1 Jun 15, 2019
@patzick patzick removed the feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can label Jun 18, 2019
patzick added a commit that referenced this issue Jun 18, 2019
…n-product-page

Bugfix/#3056 remove back icon on product page
@patzick
Copy link
Collaborator

patzick commented Jun 18, 2019

Back button on product page has been removed as it was in 1.9.
There are too many different behaviors, without proper specification of each case there is no point in having it.

@patzick patzick closed this as completed Jun 18, 2019
@patzick patzick added 1: Easy QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 18, 2019
@alinadivante alinadivante added QA approved after merge Testers will add this label after positive check on merged changes and removed QA - Ready for tests This is notification for testers, that improvement is ready to be tested and verified. labels Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports QA approved after merge Testers will add this label after positive check on merged changes
Projects
None yet
Development

No branches or pull requests

5 participants