Product labels new and sale use an incorrect boolean type

[themreza]

Current behavior

The vue-storefront/core/modules/catalog/components/ProductTile.ts component looks for two fields in the ElasticSearch product record to decide if the new and sale labels should be displayed on each product.

The checks for these fields assumes the fields to be of type string with an exact value of '1'.

Expected behavior

The fields should accept the standard true / false boolean types as input.

Steps to reproduce the issue

Repository

https://github.com/DivanteLtd/vue-storefront/blob/release/v1.11/core/modules/catalog/components/ProductTile.ts#L37

Can you handle fixing this bug by yourself?

• YES
• NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

• This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
• This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
• This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

• Browser:
• OS:
• Node:
• Code Version:

Additional information

[andrzejewsky]

thanks for reporting @themreza, actually we've fixed something similar, looks like easy to fix

[WaleedTikken]

It has been fixed along with the product display on latest option. :)

[WaleedTikken]

Just changed the default sort to

"sort": "updated_at",
instead of

"sort": "updated_at:desc",

[themreza]

Just changed the default sort to

"sort": "updated_at",
instead of

"sort": "updated_at:desc",

What does the sort order have to do with new and special labels?

If it was fixed, would you please share the link to the new ProductTile.ts?

[andrzejewsky]

@WaleedTikken we've fixed issue with the sorting functionality on the category page and nothing else, this is about the isOnSale or isNew - it won't work if the value is different than '1' @themreza is right.