Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next: Get rid of ckoWebHookUrl attribute #4910

Closed
2 of 7 tasks
Fifciu opened this issue Sep 24, 2020 · 0 comments
Closed
2 of 7 tasks

Next: Get rid of ckoWebHookUrl attribute #4910

Fifciu opened this issue Sep 24, 2020 · 0 comments
Assignees
@Fifciu
Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront

Comments

@Fifciu
Copy link
Collaborator

Fifciu commented Sep 24, 2020

What is the motivation for adding / enhancing this feature?

Currently, we have ckoWebHookUrl and ctApiUrl attributes inside config. We should get rid of ckoWebHookUrl and replace it to ctApiUrl in each place where old attribute has been used.

What are the acceptance criteria

  • Update config interface
  • Update readme
  • Make sure ckoWebHookUrl is not being used neither in src nor nuxt directory

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Can you complete this feature request by yourself?

  • YES
  • NO
@Fifciu Fifciu added good first issue Tasks that requires just basic understanding of Vue Storefront feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can 1: Easy labels Sep 24, 2020
@Fifciu Fifciu added this to Backlog in Next Core 1.0 via automation Sep 24, 2020
@Fifciu Fifciu self-assigned this Sep 24, 2020
@Fifciu Fifciu mentioned this issue Sep 25, 2020
Merged
6 tasks
@filrak filrak removed this from Backlog in Next Core 1.0 Sep 29, 2020
@Fifciu Fifciu closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fifciu Fifciu

Labels
1: Easy feature request Requests for new features. Please be as specific as possible and provide proposal API if it you can good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fifciu