Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKO - Better card token handling #4928

Closed
3 of 9 tasks
Fifciu opened this issue Sep 28, 2020 · 0 comments
Closed
3 of 9 tasks

CKO - Better card token handling #4928

Fifciu opened this issue Sep 28, 2020 · 0 comments
Assignees
Labels
3: Medium complexity bug Bug reports Next Issues/bugs for Vue Storefront Next

Comments

@Fifciu
Copy link
Collaborator

Fifciu commented Sep 28, 2020

Current behavior

We are storing card/instrument token inside localStorage.

Expected behavior

We should store it in sessionStorage and remove it if someone leaves checkout.

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Todo

  • localStorage -> sessionStorage
  • remove stored token in onUnmounted
@Fifciu Fifciu added bug Bug reports 3: Medium complexity Next Issues/bugs for Vue Storefront Next labels Sep 28, 2020
@Fifciu Fifciu added this to Backlog in Next Core 1.0 via automation Sep 28, 2020
@Fifciu Fifciu self-assigned this Sep 28, 2020
@filrak filrak removed this from Backlog in Next Core 1.0 Sep 29, 2020
@Fifciu Fifciu closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Medium complexity bug Bug reports Next Issues/bugs for Vue Storefront Next
Projects
None yet
Development

No branches or pull requests

1 participant