[WIP] Cms integration #1325
Closed
[WIP] Cms integration #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got the idea, for me it's just fine. Maybe we should cache the blocks in the indexedDb to not query the server each time? if there will be external API call for getting the blocks as I assume is the case here - it won't be cached by default (only Elastic calls are cached by default). Please consider it. Some checks are failing - please fix it before the merge. |
|
Yes, it will be saved to indexedDB as any other resource. It's just not finished yet. |
|
So, no Elasticsearch? How do you plan to handle search? |
|
@DavidRouyer I'll adjust my PR to current magento cms integration which is using es :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMS integration for Vue Storefront.
I'm starting with abstract boilerplate for generic use which will be combined with extensions for each platform (eg contentful, wordpress etc).
The extensions are developed on separate repos